-
Notifications
You must be signed in to change notification settings - Fork 13.4k
{aarch64,x86_64}-pc-windows-gnullvm: build host tools #140772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
r? @marcoieni rustbot has assigned @marcoieni. Use |
This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp. |
Forgot to include |
ok, so I guess we need to try this, right? @bors try |
{aarch64,x86_64}-*-windows-gnullvm: build host tools This will require MCP, but I suppose we need to know how long it takes to build first. I opted for bootstrapping from Linux because that's the easiest host system to work with, but once this hits beta, having dedicated Windows runners would be sensible and probably preferable. `--enable-full-tools` for whatever reason doesn't seem to work when cross-compiling, because LLVM tools for the new hosts are not copied into the expected directory. And WiX that bootstrap relies upon to create .msi installers only supports Windows. I haven't tried, but it might be usable via Wine. Almost every commit is self-contained, so let me know if I should split them into separate PRs. try-job: dist-windows-gnullvm
This comment has been minimized.
This comment has been minimized.
maybe you need to add the job to the |
💥 Test timed out |
Oh, right. Totally forgot about it. |
@bors try |
{aarch64,x86_64}-*-windows-gnullvm: build host tools This will require MCP, but I suppose we need to know how long it takes to build first. I opted for bootstrapping from Linux because that's the easiest host system to work with, but once this hits beta, having dedicated Windows runners would be sensible and probably preferable. `--enable-full-tools` for whatever reason doesn't seem to work when cross-compiling, because LLVM tools for the new hosts are not copied into the expected directory. And WiX that bootstrap relies upon to create .msi installers only supports Windows. I haven't tried, but it might be usable via Wine. Almost every commit is self-contained, so let me know if I should split them into separate PRs. try-job: dist-windows-gnullvm
This comment has been minimized.
This comment has been minimized.
💔 Test failed - checks-actions |
Unfortunately, free CI runners are not as capable as I had hoped. I've split the jobs now, but dunno if this will be acceptable. |
yes, we prefer multiple free runner compared to 1 large runner 👍 @bors try |
{aarch64,x86_64}-*-windows-gnullvm: build host tools This will require MCP, but I suppose we need to know how long it takes to build first. I opted for bootstrapping from Linux because that's the easiest host system to work with, but once this hits beta, having dedicated Windows runners would be sensible and probably preferable. `--enable-full-tools` for whatever reason doesn't seem to work when cross-compiling, because LLVM tools for the new hosts are not copied into the expected directory. And WiX that bootstrap relies upon to create .msi installers only supports Windows. I haven't tried, but it might be usable via Wine. Almost every commit is self-contained, so let me know if I should split them into separate PRs. try-job: dist-aarch64-windows-gnullvm try-job: dist-x86_64-windows-gnullvm
This comment has been minimized.
This comment has been minimized.
💔 Test failed - checks-actions |
@bors try |
mmh so you are saying that in a few weeks you are going to open a new PR to edit this code? Why not edit it now? 🤔 |
src/ci/docker/host-x86_64/dist-aarch64-windows-gnullvm/Dockerfile
Outdated
Show resolved
Hide resolved
src/ci/docker/host-x86_64/dist-aarch64-windows-gnullvm/Dockerfile
Outdated
Show resolved
Hide resolved
src/ci/docker/host-x86_64/dist-aarch64-windows-gnullvm/Dockerfile
Outdated
Show resolved
Hide resolved
src/ci/docker/host-x86_64/dist-x86_64-windows-gnullvm/Dockerfile
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file is very similar to [dist-aarch64-windows-gnullvm/install-llvm-mingw.sh](https://github.com/rust-lang/rust/pull/140772/files#diff-aa3918ad02d118bc5907a7d19827d8b3de442f35cde1b590b60261dee2852c07)
.
Can we share the logic somehow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I could add environment variable, configured from the Dockerfile, and use it in line 11. Then we need only a single script.
@bors2 try |
{aarch64,x86_64}-*-windows-gnullvm: build host tools This will require MCP, but I suppose we need to know how long it takes to build first. I opted for bootstrapping from Linux because that's the easiest host system to work with, but once this hits beta, having dedicated Windows runners would be sensible and probably preferable. `--enable-full-tools` for whatever reason doesn't seem to work when cross-compiling, because LLVM tools for the new hosts are not copied into the expected directory. And WiX that bootstrap relies upon to create .msi installers only supports Windows. I haven't tried, but it might be usable via Wine. Almost every commit is self-contained, so let me know if I should split them into separate PRs. try-job: dist-aarch64-windows-gnullvm try-job: dist-x86_64-windows-gnullvm
Right now all |
…=Kobzol Don't create .msi installer for gnullvm hosts WIX toolset works only on Windows hosts, but gnullvm doesn't have host toolchain yet. To get out of this loop, we will create a single release without MSI installer. Split out from: rust-lang/rust#140772
This is done now and both builds pass locally. Also updated llvm-mingw, this release includes the final mingw-w64 v13 release instead of the pinned trunk commit (it doesn't change much but could be seen as a nice thing to use the final release). |
Thanks! This looks good. You can squash the commit and r=me 👍 @bors2 try |
{aarch64,x86_64}-*-windows-gnullvm: build host tools This will require MCP, but I suppose we need to know how long it takes to build first. I opted for bootstrapping from Linux because that's the easiest host system to work with, but once this hits beta, having dedicated Windows runners would be sensible and probably preferable. `--enable-full-tools` for whatever reason doesn't seem to work when cross-compiling, because LLVM tools for the new hosts are not copied into the expected directory. And WiX that bootstrap relies upon to create .msi installers only supports Windows. I haven't tried, but it might be usable via Wine. Almost every commit is self-contained, so let me know if I should split them into separate PRs. try-job: dist-aarch64-windows-gnullvm try-job: dist-x86_64-windows-gnullvm
Thanks! @bors r=marcoieni |
Some changes occurred in src/doc/rustc/src/platform-support cc @Noratrieb |
Sorry, almost forgot about the docs. Let's wait with merging until @Noratrieb gets a chance to review them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me on the docs after fixing it
@@ -147,8 +149,7 @@ target | std | notes | |||
[`aarch64-apple-ios-macabi`](platform-support/apple-ios-macabi.md) | ✓ | Mac Catalyst on ARM64 | |||
[`aarch64-apple-ios-sim`](platform-support/apple-ios.md) | ✓ | Apple iOS Simulator on ARM64 | |||
[`aarch64-linux-android`](platform-support/android.md) | ✓ | ARM64 Android | |||
[`aarch64-pc-windows-gnullvm`](platform-support/windows-gnullvm.md) | ✓ | ARM64 MinGW (Windows 10+), LLVM ABI | |||
[`aarch64-unknown-fuchsia`](platform-support/fuchsia.md) | ✓ | ARM64 Fuchsia | |||
`aarch64-unknown-fuchsia`](platform-support/fuchsia.md) | ✓ | ARM64 Fuchsia |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you broke the [
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oof, good catch. Just when I thought my switch from Vim style bindings to Helix style is going well...
@bors r=marcoieni,Noratrieb |
This is a temporary single-release workflow to create stage0 for these targets.
I opted for bootstrapping from Linux because that's the easiest host system to work with, but once this hits beta, having dedicated Windows runners would be sensible and probably preferable.
--enable-full-tools
for whatever reason doesn't seem to work when cross-compiling, because LLVM tools for the new hosts are not copied into the expected directory.rust-lang/compiler-team#877